refactor: Fix CallbackPlugin to on add callbacks once #744
+93
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL refactors the `CallbackPlugin` to ensure that callbacks are only added once, making the `add*Callback` methods idempotent. Key changes include: * Introduction of a new private method `addCallbackImpl` that checks for the existence of a callback before adding it and its corresponding plugin. * Modification of all `add*Callback` methods (e.g., `addBeforeAgentCallback`, `addAfterAgentCallback`) to utilize `addCallbackImpl`. * Removal of a temporary workaround method `clearBeforeModelCallbacks` from both `CallbackPlugin` and `LlmAgent`. * Addition of a new test case `addBeforeModelCallback_isIdempotent` in `CallbackPluginTest` to verify the new idempotent behavior. PiperOrigin-RevId: 858210973
copybara-service
bot
force-pushed
the
test_858210973
branch
from
f1eaebe to
1585935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Fix CallbackPlugin to on add callbacks once
This CL refactors the
CallbackPluginto ensure that callbacks are only added once, making theadd*Callbackmethods idempotent.Key changes include:
addCallbackImplthat checks for the existence of a callback before adding it and its corresponding plugin.add*Callbackmethods (e.g.,addBeforeAgentCallback,addAfterAgentCallback) to utilizeaddCallbackImpl.clearBeforeModelCallbacksfrom bothCallbackPluginandLlmAgent.addBeforeModelCallback_isIdempotentinCallbackPluginTestto verify the new idempotent behavior.