fix(rust: builder): add lifetime bounds to finish methods#8750
Open
dallasmarlow wants to merge 2 commits intogoogle:masterfrom
Open
fix(rust: builder): add lifetime bounds to finish methods#8750dallasmarlow wants to merge 2 commits intogoogle:masterfrom
dallasmarlow wants to merge 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dallasmarlow
force-pushed
the
rust-finish-lifetime-fix
branch
from
9f794ee to
57a9222
Compare
dallasmarlow
force-pushed
the
rust-finish-lifetime-fix
branch
from
a3134b3 to
002656f
Compare
dallasmarlow
force-pushed
the
rust-finish-lifetime-fix
branch
from
002656f to
aa8f80f
Compare
Collaborator
|
this seems good to me (as a rust n00b) -- is there a way we can write a regression test against this as part of this PR? |
jtdavis777
added
the
waiting-for-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a reported issue where a FlatBufferBuilder could be finished with a WIPOffset created by a different builder.
Calling builder1.finish(offset_from_builder2) would compile but result in a runtime panic or data corruption, as the offset is meaningless in builder1's buffer.
The fix enforces the builder's lifetime ('fbb) on the generic type T of the WIPOffset in all finish methods (finish, finish_minimal, finish_size_prefixed, and finish_with_opts).
#8698