Skip to content

Handle trust-constr callback state arg in ScipyMinimize - #648

Open
Whning0513 wants to merge 1 commit into
google:mainfrom
Whning0513:fix-trust-constr-callback-636
Open

Handle trust-constr callback state arg in ScipyMinimize#648
Whning0513 wants to merge 1 commit into
google:mainfrom
Whning0513:fix-trust-constr-callback-636

Conversation

@Whning0513

Copy link
Copy Markdown

Summary

  • accept SciPy callback state arguments in ScipyMinimize._run() instead of assuming every method calls callback(xk)
  • add a focused regression test covering the trust-constr callback shape that passes (xk, state)

Testing

  • python -m pytest -q tests/scipy_wrappers_callback_test.py

I only ran the focused regression test here because this environment does not have the full jax test stack installed.

Fixes #636.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: jaxopt.ScipyMinimize only allows callable(xk), which fails for trust-constr

1 participant