Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to 9.4.1.
The biggest change is to the
checkLicensetask, which must run with the--no-parallelflag.This is a known issue with the plugin, and difficult to work around. E.g., the mutex pattern,
which enforces sequential task execution, does not help due to problem with task execution order.
We detach
checkLicensefrombuildso that the latter can still take advantage of parallelism.Presubmit and release scripts that care about licenses must explicitly call checkLicense with the
--no-parallelflag.Other changes include plugin version upgrade, plugin replacement (e.g., shadowjar), explicit task
dependency declaration, and minor syntax change.
This change is