Improve Cleanup Function Naming in Generated Code

internal/wire/testdata/CleanupNameCollision/foo/foo.go

@@ -0,0 +1,46 @@
+// Copyright 2018 The Wire Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"fmt"
+)
+
+func main() {
+	bar, cleanup := injectFooCleanup()
+	fmt.Println(*bar)
+	cleanup()
+	fmt.Println(*bar)
+}
+
+type Foo int
+type FooCleanup int
+
+func provideFoo() (*Foo, func()) {
+	foo := new(Foo)
+	*foo = 42
+	return foo, func() { *foo = 0 }
+}
+
+func provideFooCleanup(foo *Foo) (*FooCleanup, func()) {
+	fooCleanup := new(FooCleanup)
+	*fooCleanup = 77
+	return fooCleanup, func() {
+		if *foo == 0 {
+			panic("foo cleaned up before foo cleanup")
+		}
+		*fooCleanup = 0
+	}
+}

internal/wire/testdata/CleanupNameCollision/foo/wire.go

@@ -0,0 +1,27 @@
+// Copyright 2018 The Wire Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+//go:build wireinject
+// +build wireinject
+
+package main
+
+import (
+	"github.com/google/wire"
+)
+
+func injectFooCleanup() (*FooCleanup, func()) {
+	wire.Build(provideFoo, provideFooCleanup)
+	return nil, nil
+}

internal/wire/testdata/CleanupNameCollision/pkg

@@ -0,0 +1 @@
+example.com/foo

internal/wire/testdata/CleanupNameCollision/want/program_out.txt

@@ -0,0 +1,2 @@
+77
+0

internal/wire/wire.go

@@ -673,7 +673,7 @@ func (ig *injectorGen) funcProviderCall(lname string, c *call, injectSig outputS
 	ig.p("\t%s", lname)
 	prevCleanup := len(ig.cleanupNames)
 	if c.hasCleanup {
-		cname := disambiguate("cleanup", ig.nameInInjector)
+		cname := disambiguate(lname+"Cleanup", ig.nameInInjector)
 		ig.cleanupNames = append(ig.cleanupNames, cname)
 		ig.p(", %s", cname)
 	}