-
Notifications
You must be signed in to change notification settings - Fork 138
[macros] Fix doc bug in transmute_mut!
#2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When we updated `transmute_mut!` to support unsized types, we forgot to update one location in the documentation to reflect this. gherrit-pr-id: Gf4fc8f4ade59c568c9fef502015da09b4a508560
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a documentation discrepancy for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a good change that fixes a documentation bug in transmute_mut!. The documentation is now correctly updated to reflect support for unsized types, which aligns with the macro's capabilities. The change is correct and well-scoped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 19 19
Lines 5868 5868
=======================================
Hits 5416 5416
Misses 452 452 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When we updated
transmute_mut!to support unsized types, we forgot toupdate one location in the documentation to reflect this.
try_transmute_{ref,mut}!#2944transmute_{ref,mut}!#2943transmute_mut!#2951Stacked PRs enabled by GHerrit.