Skip to content

PHP 8.4: Fix nullable is deprecated #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mukeshpanchal27 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PHP 8.4: Fix nullable is deprecated #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Google/Ads/GoogleAds/Lib/GoogleAdsMiddlewareAbstract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ abstract class GoogleAdsMiddlewareAbstract
*
* @param callable|null $nextHandler the next handler
*/
public function __construct(callable $nextHandler = null)
public function __construct(?callable $nextHandler = null)
{
$this->nextHandler = $nextHandler;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Google/Ads/GoogleAds/Lib/InsecureCredentialsWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class InsecureCredentialsWrapper extends CredentialsWrapper
*/
public function __construct(
FetchAuthTokenInterface $credentialsFetcher,
callable $authHttpHandler = null
?callable $authHttpHandler = null
) {
parent::__construct($credentialsFetcher, $authHttpHandler);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Google/Ads/GoogleAds/Lib/V19/ServerStreamingGoogleAdsExceptionMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ class ServerStreamingGoogleAdsExceptionMiddleware extends GoogleAdsMiddlewareAbs
* @param StatusMetadataExtractor|null $statusMetadataExtractor
*/
public function __construct(
callable $nextHandler = null,
StatusMetadataExtractor $statusMetadataExtractor = null
?callable $nextHandler = null,
?StatusMetadataExtractor $statusMetadataExtractor = null
) {
parent::__construct($nextHandler);
$this->statusMetadataExtractor = $statusMetadataExtractor ?: new StatusMetadataExtractor();
Expand Down
4 changes: 2 additions & 2 deletions src/Google/Ads/GoogleAds/Lib/V19/UnaryGoogleAdsExceptionMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ class UnaryGoogleAdsExceptionMiddleware extends GoogleAdsMiddlewareAbstract
* @param StatusMetadataExtractor|null $statusMetadataExtractor
*/
public function __construct(
callable $nextHandler = null,
StatusMetadataExtractor $statusMetadataExtractor = null
?callable $nextHandler = null,
?StatusMetadataExtractor $statusMetadataExtractor = null
) {
parent::__construct($nextHandler);
$this->statusMetadataExtractor = $statusMetadataExtractor ?: new StatusMetadataExtractor();
Expand Down
2 changes: 1 addition & 1 deletion src/Google/Ads/GoogleAds/Lib/V19/UnaryGoogleAdsResponseMetadataCallable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class UnaryGoogleAdsResponseMetadataCallable extends GoogleAdsMiddlewareAbstract

private $adsClient;

public function __construct(callable $nextHandler = null, $adsClient = null)
public function __construct(?callable $nextHandler = null, $adsClient = null)
{
$this->adsClient = $adsClient;
parent::__construct($nextHandler);
Expand Down
4 changes: 2 additions & 2 deletions src/Google/Ads/GoogleAds/Lib/V20/ServerStreamingGoogleAdsExceptionMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ class ServerStreamingGoogleAdsExceptionMiddleware extends GoogleAdsMiddlewareAbs
* @param StatusMetadataExtractor|null $statusMetadataExtractor
*/
public function __construct(
callable $nextHandler = null,
StatusMetadataExtractor $statusMetadataExtractor = null
?callable $nextHandler = null,
?StatusMetadataExtractor $statusMetadataExtractor = null
) {
parent::__construct($nextHandler);
$this->statusMetadataExtractor = $statusMetadataExtractor ?: new StatusMetadataExtractor();
Expand Down
4 changes: 2 additions & 2 deletions src/Google/Ads/GoogleAds/Lib/V20/UnaryGoogleAdsExceptionMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ class UnaryGoogleAdsExceptionMiddleware extends GoogleAdsMiddlewareAbstract
* @param StatusMetadataExtractor|null $statusMetadataExtractor
*/
public function __construct(
callable $nextHandler = null,
StatusMetadataExtractor $statusMetadataExtractor = null
?callable $nextHandler = null,
?StatusMetadataExtractor $statusMetadataExtractor = null
) {
parent::__construct($nextHandler);
$this->statusMetadataExtractor = $statusMetadataExtractor ?: new StatusMetadataExtractor();
Expand Down
2 changes: 1 addition & 1 deletion src/Google/Ads/GoogleAds/Lib/V20/UnaryGoogleAdsResponseMetadataCallable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class UnaryGoogleAdsResponseMetadataCallable extends GoogleAdsMiddlewareAbstract

private $adsClient;

public function __construct(callable $nextHandler = null, $adsClient = null)
public function __construct(?callable $nextHandler = null, $adsClient = null)
{
$this->adsClient = $adsClient;
parent::__construct($nextHandler);
Expand Down
4 changes: 2 additions & 2 deletions src/Google/Ads/GoogleAds/Lib/V21/ServerStreamingGoogleAdsExceptionMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ class ServerStreamingGoogleAdsExceptionMiddleware extends GoogleAdsMiddlewareAbs
* @param StatusMetadataExtractor|null $statusMetadataExtractor
*/
public function __construct(
callable $nextHandler = null,
StatusMetadataExtractor $statusMetadataExtractor = null
?callable $nextHandler = null,
?StatusMetadataExtractor $statusMetadataExtractor = null
) {
parent::__construct($nextHandler);
$this->statusMetadataExtractor = $statusMetadataExtractor ?: new StatusMetadataExtractor();
Expand Down
4 changes: 2 additions & 2 deletions src/Google/Ads/GoogleAds/Lib/V21/UnaryGoogleAdsExceptionMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ class UnaryGoogleAdsExceptionMiddleware extends GoogleAdsMiddlewareAbstract
* @param StatusMetadataExtractor|null $statusMetadataExtractor
*/
public function __construct(
callable $nextHandler = null,
StatusMetadataExtractor $statusMetadataExtractor = null
?callable $nextHandler = null,
?StatusMetadataExtractor $statusMetadataExtractor = null
) {
parent::__construct($nextHandler);
$this->statusMetadataExtractor = $statusMetadataExtractor ?: new StatusMetadataExtractor();
Expand Down
2 changes: 1 addition & 1 deletion src/Google/Ads/GoogleAds/Lib/V21/UnaryGoogleAdsResponseMetadataCallable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class UnaryGoogleAdsResponseMetadataCallable extends GoogleAdsMiddlewareAbstract

private $adsClient;

public function __construct(callable $nextHandler = null, $adsClient = null)
public function __construct(?callable $nextHandler = null, $adsClient = null)
{
$this->adsClient = $adsClient;
parent::__construct($nextHandler);
Expand Down