fix: Replace deprecated utcfromtimestamp with helper #1905
Conversation
Replaced deprecated `datetime.utcfromtimestamp()` with a new helper function `google.auth._helpers.utcfromtimestamp()` that returns a timezone-naive UTC datetime. This ensures compatibility with the existing codebase (which uses naive datetimes) while resolving the deprecation warning. * Added `utcfromtimestamp` to `google/auth/_helpers.py`. * Updated `google/oauth2/_client.py`, `google/oauth2/_client_async.py`, `google/auth/impersonated_credentials.py`, `google/auth/app_engine.py`, `google/auth/compute_engine/credentials.py` to use the helper. * Reverted changes in tests that incorrectly mocked `utcnow` to return timezone-aware datetimes. * Verified that tests pass and no `TypeError` occurs during credential expiry checks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
1 participant
Replaced deprecated
datetime.utcfromtimestamp()with a new helper functiongoogle.auth._helpers.utcfromtimestamp()that returns a timezone-naive UTC datetime. This ensures compatibility with the existing codebase (which uses naive datetimes) while resolving the deprecation warning.utcfromtimestamptogoogle/auth/_helpers.py.google/oauth2/_client.py,google/oauth2/_client_async.py,google/auth/impersonated_credentials.py,google/auth/app_engine.py,google/auth/compute_engine/credentials.pyto use the helper.utcnowto return timezone-aware datetimes.TypeErroroccurs during credential expiry checks.PR created automatically by Jules for task 4466514792942764239 started by @chalmerlowe