Skip to content

feat: API configuration: 20260507T090101Z#15605

Merged
amanda-tarafa merged 1 commit intomainfrom
librarian-config-20260507T090101Z
May 7, 2026
Merged

feat: API configuration: 20260507T090101Z#15605
amanda-tarafa merged 1 commit intomainfrom
librarian-config-20260507T090101Z

Conversation

@google-cloud-sdk-librarian-dotnet-robot
Copy link
Copy Markdown
Collaborator

Changes in this PR

  • Configured library Google.Cloud.GeminiDataAnalytics.V1 for API google/cloud/geminidataanalytics/v1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Pull request diff results
No APIs have changed in this PR. Exiting diff.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the Google.Cloud.GeminiDataAnalytics.V1 API to the generator input and pipeline state files. The review feedback suggests updating the product name for consistency with the description and reordering the new entry in the pipeline state to maintain alphabetical sorting.

Comment thread generator-input/apis.json
Comment on lines +5030 to 5041
{
"id": "Google.Cloud.GeminiDataAnalytics.V1",
"nextVersion": "1.0.0-beta01",
"generationAutomationLevel": "AUTOMATION_LEVEL_AUTOMATIC",
"releaseAutomationLevel": "AUTOMATION_LEVEL_BLOCKED",
"apiPaths": [
"google/cloud/geminidataanalytics/v1"
],
"sourcePaths": [
"apis/Google.Cloud.GeminiDataAnalytics.V1/Google.Cloud.GeminiDataAnalytics.V1"
]
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new entry for Google.Cloud.GeminiDataAnalytics.V1 is added at the end of the entries array, which breaks the alphabetical sorting of the file. This file is maintained in alphabetical order by the id field to ensure maintainability and reduce merge conflicts. Please move this entry to its correct alphabetical position (it should appear before Google.DevicesAndServices.Health.V4).

@jskeet jskeet requested a review from amanda-tarafa May 7, 2026 09:12
@jskeet
Copy link
Copy Markdown
Collaborator

jskeet commented May 7, 2026

@amanda-tarafa Assigned this to you for now in the spirit of hand-off. Happy to shepherd this through if you'd like, but equally happy to step back.

@amanda-tarafa amanda-tarafa merged commit 2777da9 into main May 7, 2026
14 checks passed
@amanda-tarafa amanda-tarafa deleted the librarian-config-20260507T090101Z branch May 7, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants