test(showcase): Add gRPC PQC Showcase integration tests - #13969
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependency versions for gRPC, Gson, and Error Prone across several pom.xml files. It also introduces a new integration test, testGrpcPqc_withTls, in ITPostQuantumCryptography.java to verify Post-Quantum Cryptography (PQC) TLS negotiation for gRPC clients. Feedback on the changes highlights a potential data race and visibility issue in the custom gRPC client interceptor used in the test, where capturedMetadata is mutated on the gRPC transport thread and read on the main test thread without synchronization. A suggestion is provided to make the field volatile and safely publish a copy of the metadata.
c276c35 to
16c429d
Compare
5e1cce9 to
7a7f7ad
Compare
|
|
|
The test is failing due to the error below Is this expected? |
taking a look. This shouldn't be the case |
7a7f7ad to
860a865
Compare
- Add testGrpcPqc_withTls Showcase TLS integration test in ITPostQuantumCryptography.java using built-in default gRPC transport, configured to trust the Showcase TLS server certificate directly. - Include concise Javadoc documenting gRPC built-in PQC behavior and explaining the purpose of GrpcTlsCapturingClientInterceptor and HTTP/2 metadata helper methods. - Declare capturedMetadata volatile and assign a merged copy in onHeaders for thread-safe metadata publication. - Assert negotiated group is equal to EXPECTED_PQC_GROUP for gRPC without asserting a supported groups list. - Leave all HTTP/JSON tests and setUp() 100% untouched. - Exclude all mTLS test resources, keys, certs, and mTLS logic.
860a865 to
2f97a2b
Compare
2 participants
No description provided.