-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(bigquery-jdbc): add picosecond precision support for TIMESTAMP #14038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keshavdandeva
wants to merge
2
commits into
jdbc/timestamp-normalization
from
jdbc/picosecond-precision
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,6 +51,16 @@ Statement getStatement() { | |
| return this.statement; | ||
| } | ||
|
|
||
| private boolean isTimestampPicosEnabled() { | ||
| return this.statement instanceof BigQueryStatement | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: maybe using |
||
| && ((BigQueryStatement) this.statement).isEnableTimestampPicos(); | ||
| } | ||
|
|
||
| private boolean supportsPicoseconds(int sqlColumn) { | ||
| Long timestampPrecision = getField(sqlColumn).getTimestampPrecision(); | ||
| return timestampPrecision != null && timestampPrecision > 6; | ||
| } | ||
|
|
||
| private Field getField(int sqlColumn) { | ||
| return this.schemaFieldList.get(sqlColumn - 1); | ||
| } | ||
|
|
@@ -116,7 +126,10 @@ public int getColumnDisplaySize(int column) { | |
| case Types.NUMERIC: | ||
| return 14; | ||
| case Types.TIMESTAMP: | ||
| return 16; | ||
| if (isTimestampPicosEnabled() && supportsPicoseconds(column)) { | ||
| return 32; | ||
| } | ||
| return 26; | ||
| default: | ||
| return DEFAULT_DISPLAY_SIZE; | ||
| } | ||
|
|
@@ -139,6 +152,11 @@ public int getPrecision(int column) { | |
| return precision.intValue(); | ||
| } | ||
| StandardSQLTypeName type = getStandardSQLTypeName(column); | ||
| if (type == StandardSQLTypeName.TIMESTAMP | ||
| && isTimestampPicosEnabled() | ||
| && supportsPicoseconds(column)) { | ||
| return 32; | ||
| } | ||
| BigQueryJdbcTypeMappings.ColumnTypeInfo typeInfo = | ||
| BigQueryJdbcTypeMappings.STANDARD_TYPE_INFO.get(type); | ||
| if (typeInfo != null && typeInfo.columnSize != null) { | ||
|
|
@@ -154,6 +172,11 @@ public int getScale(int column) { | |
| return scale.intValue(); | ||
| } | ||
| StandardSQLTypeName type = getStandardSQLTypeName(column); | ||
| if (type == StandardSQLTypeName.TIMESTAMP | ||
| && isTimestampPicosEnabled() | ||
| && supportsPicoseconds(column)) { | ||
| return 12; | ||
| } | ||
| BigQueryJdbcTypeMappings.ColumnTypeInfo typeInfo = | ||
| BigQueryJdbcTypeMappings.STANDARD_TYPE_INFO.get(type); | ||
| if (typeInfo != null && typeInfo.decimalDigits != null) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.