test(pubsub): disable flaky testRunShutdown_TimeoutExceeded in StreamingSubscriberConnectionTest - #14146
Merged
Conversation
…ingSubscriberConnectionTest Disable `testRunShutdown_TimeoutExceeded` in `StreamingSubscriberConnectionTest` which hangs during shutdown synchronization, and re-enable `testSendAckOperationsExactlyOnceEnabledErrorWithEmptyMetadataMap`. From #13706
Member
Author
|
@michaelpri10 FYI |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates StreamingSubscriberConnectionTest.java by ignoring the testRunShutdown_TimeoutExceeded test due to an open issue, and re-enabling the testSendAckOperationsExactlyOnceEnabledErrorWithEmptyMetadataMap test by removing its @ignore annotation. There are no review comments, and I have no feedback to provide.
michaelpri10
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flakiness exists again even though the test was disabled. After another look, it seems this test is most likely the cause (spawning new threads).
From #13706