test(bigtable): resolve NullArgumentForNonNullParameter error in MaybePointWriteCallableTest - #14179
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates MaybePointWriteCallableTest.java by simplifying an assertion on a future's result in singleEntry_routesToPointWriter and adding an assertion to verify that the returned future is the same instance as the classic response in multipleEntries_fallsThroughToClassic. I have no feedback to provide.
lqiu96
changed the title
…PointWriteCallableTest Fixes #14174 Replace redundant Truth assertThat((Object) future.get()).isNull() on ApiFuture<Void> with direct future.get() to avoid ErrorProne NullArgumentForNonNullParameter false-positives under GraalVM / JDK 21 CI.
lqiu96
force-pushed
the
fix-14174-bigtable-native-compile
branch
from
August 24, 2026 20:30
710d7f3 to
14d14c2
Compare
mutianf
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14174
Problem
During GraalVM native presubmit CI compilation under JDK 21 with ErrorProne enabled,
MaybePointWriteCallableTest.javafailed with:[NullArgumentForNonNullParameter]at line 59:assertThat((Object) future.get()).isNull().future.get()onApiFuture<Void>evaluates tonull(or throws an exception).@Nullableparameter annotation onassertThat(@Nullable Object actual)inside the@NullMarkedpackage when reading bytecode in CI, flagging passing a known-null value.Solution
Replace
assertThat((Object) future.get()).isNull()with directfuture.get()to verify successful completion without exception.