Skip to content

feat(apptopology): onboard a new library - #14204

Open
noahdietz wants to merge 2 commits into
mainfrom
onboard-apptopology
Open

feat(apptopology): onboard a new library#14204
noahdietz wants to merge 2 commits into
mainfrom
onboard-apptopology

Conversation

@noahdietz

Copy link
Copy Markdown
Contributor

Onboard google/cloud/apptopology/v1 to google-cloud-java using Librarian.

Internal tracking bug http://b/551671086

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new Google App Topology Client for Java, including auto-generated client code, stubs, configurations, and unit tests for both gRPC and HTTP/JSON transports. A review comment suggests populating the api_description field in .repo-metadata.json to prevent a broken sentence in the generated README.

"api_shortname": "apptopology",
"name_pretty": "App Topology",
"product_documentation": "https://docs.cloud.google.com/app-topology",
"api_description": "",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The api_description field is currently empty. Populating this field with a brief description of the App Topology service automatically populates the "About App Topology" section in the generated README.md, which currently contains a broken/incomplete sentence [App Topology][product-docs].

Suggested change
"api_description": "",
"api_description": "describes handlers for resources and generates topologies.",

@noahdietz
noahdietz marked this pull request as ready for review August 27, 2026 21:27
@noahdietz
noahdietz requested review from a team as code owners August 27, 2026 21:27
@snippet-bot

snippet-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 27 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@noahdietz
noahdietz enabled auto-merge (squash) August 27, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants