chore: update to librarian v0.13.0 / generator 1.32.0 (with adjustments) #17042
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependency version requirements for google-api-core and grpcio across multiple post-processing configuration files, removes legacy replacement rules for constraints files, and deletes several obsolete configuration files. Feedback suggests correcting a potential version mismatch in a replacement block within storage-integration.yaml and cautions against removing version pins in constraints files, as this may lead to non-deterministic build environments.
| google-auth | ||
| # cryptography is a direct dependency of google-auth | ||
| cryptography | ||
| google-api-core==2.27.0 | ||
| google-cloud-core==2.4.2 | ||
| google-resumable-media==2.7.2 | ||
| grpcio==1.33.2 | ||
| requests==2.22.0 | ||
| google-crc32c==1.6.0 | ||
| protobuf==4.25.8 | ||
| opentelemetry-api==1.1.0 | ||
| google-api-core | ||
| google-cloud-core | ||
| google-resumable-media | ||
| grpcio | ||
| requests | ||
| google-crc32c | ||
| protobuf | ||
| opentelemetry-api |
There was a problem hiding this comment.
The after block for the constraints-*.txt replacements has been updated to remove all version pins (e.g., google-auth, google-api-core). Constraints files are typically expected to have pinned versions to ensure reproducible and stable test environments. Removing these pins might lead to non-deterministic builds or CI failures if incompatible transitive dependencies are pulled in.
Given that similar constraints replacements were removed entirely from other integration files in this PR, consider if this replacement is still necessary or if it should maintain pinned versions.
There was a problem hiding this comment.
The filename being adjusted is changed as well - basically this is to make sure that constraints-3.10.txt doesn't get changed (at least not significantly).
I can't remember offhand why I had to remove it from line 658, but I assume it's because the generated file no longer matches.
This includes gapic-generator 1.32.0.
jskeet
changed the title
jskeet
force-pushed
the
update-post-processor
branch
from
9b609be to
f36d765
Compare
3 participants
Adjusts the string replacement post-processor configurations to be ready for librarian v0.13.0 which uses gapic-generator 1.32.0. This change does not include the results of regeneration; those changes will be done immediately afterwards, in batches.