-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(handwritten): centralize mypy configuration and update handwritten package noxfiles #17409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chalmerlowe
wants to merge
18
commits into
main
Choose a base branch
from
feat/centralize-mypy-handwritten
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bedd2f2
feat(handwritten): centralize mypy.ini and update noxfiles
chalmerlowe d449d71
style(mypy): format modified noxfile.py files with black
chalmerlowe 15b1b64
fix(handwritten): use dynamic parent-directory traversal for mypy.ini…
chalmerlowe 9defb81
style(handwritten): format modified noxfiles according to style guide
chalmerlowe b1456a6
chore: restore mypy.ini and noxfile.py for google-crc32c
chalmerlowe 234bd93
chore: removes blank spaces from file
chalmerlowe b520bb7
chore: restores bigframes files due to system test issues
chalmerlowe bda8f95
chore: restores bigframes files due to system test issues
chalmerlowe 5fada6e
chore: revert changes for overreaching generated packages
chalmerlowe 2f63dcc
feat(handwritten): centralize mypy config for hybrid packages and add…
chalmerlowe 5db0eda
chore: remove scratch files from PR
chalmerlowe 24c40b4
feat(handwritten): centralize mypy config for all handwritten packages
chalmerlowe 8992e36
updates to mypy.ini re: bigtable
chalmerlowe 1fba466
updates mypy.ini to account for several package specific settings.
chalmerlowe 81c42bf
fix: resolve syntax errors in noxfiles due to escaped quotes
chalmerlowe ce4bc47
fix(mypy): add global ignores for grpc_status and google.api
chalmerlowe 4def939
fix(mypy): restore ignores for generated bigtable packages
chalmerlowe 5a22944
chore(tests): apply blacken/ruff formatting to modified noxfiles
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for reviewer:
The next few edits are the linter doing linting as opposed to new code.