chore(jdbc): add nightly JAR build #4076
Conversation
product-auto-label
bot
added
size: m
Summary of ChangesHello @logachev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a crucial automated process for the JDBC driver by introducing nightly builds. It ensures that up-to-date build artifacts, including various JAR formats and a thin ZIP, are consistently generated and made available in an internal GCS bucket. This provides a reliable foundation for ongoing development, testing, and future release preparations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a nightly build process for JDBC artifacts. The changes include a new step in the Cloud Build configuration and a new release script. My review focuses on improving the robustness and maintainability of the new shell script. I've suggested adding error handling, quoting variables to prevent shell-related issues, using short commit hashes for cleaner artifact names, and refactoring duplicated code into a function.
.kokoro/jdbc-release.sh
Outdated
| rm -rf "${FOLDER}" | ||
|
|
||
| # Update latest version | ||
| gsutil cp "${NIGHTLY_BUILD_DESTINATION}/${JAR_NAME}.zip" "${BUCKET}/google-cloud-bigquery-jdbc-latest.zip" |
There was a problem hiding this comment.
qq, how does this script do auth to determine if you have permission to upload?
There was a problem hiding this comment.
CloudBuild assigned service account has write permissions
.kokoro/jdbc-release.sh
Outdated
| DATE=$(date '+%Y-%m-%d') | ||
| COMMIT=$(git rev-parse --short HEAD) | ||
| VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout) | ||
| BUCKET=gs://bq_devtools_release_private/drivers/jdbc |
There was a problem hiding this comment.
I'm guessing customers already pull from this bucket and it's public. Just want to check if this being public is fine/ should we put this as an env var?
There was a problem hiding this comment.
That's internal bucket; I moved it to CloudBuild env
2 participants
Adding a new step in Nightly validation to build Uber JAR/Shaded Uber JAR & ZIP archive with Thin jar & upload to internal GCS bucket.
Updated pom.xml in a way that
mvn packagebuilds both - thin & uber JARs. Runningmvn deploycopies both of them to the repo, so next time release is cut I'd expect it to go to maven too.