Skip to content

tests: filter deprecation warnings related to unsupported Python runtimes #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chalmerlowe merged 7 commits into from
Jan 5, 2026
Merged

tests: filter deprecation warnings related to unsupported Python runtimes #371

chalmerlowe merged 7 commits into from
Jan 5, 2026

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 5, 2026 •
edited by chalmerlowe
Loading

This change fixes the test failures on Python 3.9 where google-api-core fails due to missing importlib.metadata.packages_distributions. It also suppresses the deprecation warning for Python 3.9 to prevent it from being treated as an error during testing under pytest.

Fixes Issue #360

PR created automatically by Jules for task 17628321005402500590 started by @chalmerlowe

@google-labs-jules
Fix Python 3.9 support by adding importlib-metadata dependency
b211cb6 
- Added `importlib-metadata >= 3.6.0` dependency for Python < 3.10 to provide `packages_distributions` needed by `google-api-core`.
- Updated `pytest.ini` to ignore `FutureWarning` and `DeprecationWarning` regarding unsupported Python 3.9 version.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 5, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: dns Issues related to the googleapis/python-dns API. labels Jan 5, 2026
@chalmerlowe chalmerlowe changed the title Fix Python 3.9 support: Add importlib-metadata and ignore deprecation warning fix: Python 3.9 support: Add importlib-metadata and ignore deprecation warning Jan 5, 2026
@chalmerlowe chalmerlowe changed the title fix: Python 3.9 support: Add importlib-metadata and ignore deprecation warning fix: Python 3.9 support - add importlib-metadata and ignore deprecation warning Jan 5, 2026
chalmerlowe
chalmerlowe reviewed Jan 5, 2026
View reviewed changes
@chalmerlowe chalmerlowe marked this pull request as ready for review January 5, 2026 14:33
@chalmerlowe chalmerlowe requested a review from a team as a code owner January 5, 2026 14:33
@google-labs-jules
Fix Python 3.9 support by adding importlib-metadata dependency
648e0a9 
- Added `importlib-metadata >= 3.6.0` dependency for Python < 3.10 to provide `packages_distributions` needed by `google-api-core`.
- Updated `pytest.ini` to ignore `FutureWarning` and `DeprecationWarning` regarding unsupported Python 3.9 version.
parthea
parthea reviewed Jan 5, 2026
View reviewed changes
chalmerlowe
chalmerlowe reviewed Jan 5, 2026
View reviewed changes
@parthea parthea changed the title fix: Python 3.9 support - add importlib-metadata and ignore deprecation warning tests: filter deprecation warnings related to unsupported Python runtimes Jan 5, 2026
parthea
parthea reviewed Jan 5, 2026
View reviewed changes
chalmerlowe
chalmerlowe reviewed Jan 5, 2026
View reviewed changes
chalmerlowe and others added 3 commits January 5, 2026 10:53
@chalmerlowe
Apply suggestion from @chalmerlowe
9f74bec
@google-labs-jules
Fix Python 3.9 support and handle PR feedback
5fad6c5 
- Updated `pytest.ini` to ignore `FutureWarning` and `DeprecationWarning` regarding unsupported Python 3.9 version.
- Commented out `importlib-metadata` dependency in `setup.py` as requested by PR review (NOTE: This will likely break Python 3.9 tests).
@google-labs-jules
Fix Python 3.9 support and handle PR feedback
329c83c 
- Updated `pytest.ini` to ignore `FutureWarning` and `DeprecationWarning` regarding unsupported Python 3.9 version.
- Reverted the addition of `importlib-metadata` dependency in `setup.py` as requested by PR review (empty suggestion interpreted as removal).
chalmerlowe
chalmerlowe approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 890caf8 into main Jan 5, 2026
18 of 20 checks passed
@chalmerlowe chalmerlowe deleted the fix-python-3.9-deps-17628321005402500590 branch January 5, 2026 16:01
This was referenced Jan 5, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels

api: dns Issues related to the googleapis/python-dns API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @chalmerlowe @daniel-sanche