fix(github-api): restore proxy-server support with undici dispatcher - #2846
Open
anishesg wants to merge 1 commit into
Open
fix(github-api): restore proxy-server support with undici dispatcher#2846anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
The `proxy-server` input was silently ignored because `@octokit/request` v8 dropped support for `request.agent` in favor of native fetch with dispatchers. The proxy configuration was being passed as `request.agent` to Octokit and GraphQL clients, but this parameter is filtered out before reaching the fetch call. Signed-off-by: anish <anishesg@users.noreply.github.com>
|
+1 I have similar issues. For what it matters...I checked and LGTM. Thanks @anishesg <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
proxy-serverinput was silently ignored because@octokit/requestv8 dropped support forrequest.agentin favor of native fetch with dispatchers. The proxy configuration was being passed asrequest.agentto Octokit and GraphQL clients, but this parameter is filtered out before reaching the fetch call.This change replaces the
createDefaultAgentmethod withcreateProxyFetchthat creates a custom fetch function using undici'sProxyAgentas a dispatcher. The proxy agent is now properly passed through the fetch options, which is compatible with@octokit/requestv8's architecture. The fix adds undici as a dependency and updates tests to validate the new proxy fetch implementation.Users who relied on the
NODE_USE_ENV_PROXY+HTTPS_PROXYworkaround will continue to work as expected, and the documentedproxy-serverinput now functions correctly.Fixes #2838