Merged
Conversation
Contributor
Author
|
I see fontc also has https://github.com/googlefonts/fontc/blob/main/.github/workflows/release.yml#L81. Should probably add something similar as well. |
Collaborator
|
I like the idea in general, but I don't like the idea of depending on pyo3 in all builds. Maybe we could hide it behind a feature? |
Contributor
Author
|
py03 removed. Next step is gha workflow to build and deploy em to pypi. Want me to add this functionality to this PR? |
anthrotype
reviewed
Jun 18, 2025
Collaborator
When you have a moment, please. A call today made me realise that the installation picture is not as rosy as I thought. |
Collaborator
|
We now have two copies of diff3proof? |
simoncozens
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After opening googlefonts/gftools#1120 @anthrotype suggested I simply just make some python wheels instead of the curl + unzip combo.