Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jan 3, 2026

Thank you for opening a Pull Request!

Fixes the options in the tests, see ApiOptions for ref


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@usefulthink
Copy link
Contributor

Thanks for spotting this! Now I'm wondering why that didn't cause any problems...

@vicb
Copy link
Contributor Author

vicb commented Jan 3, 2026

Thanks for spotting this! Now I'm wondering why that didn't cause any problems...

I don't think the tests exercize anything in the weekly. Also there is no API key anyway.

But yeah there should probably be more robust tests at some point.

@usefulthink usefulthink merged commit 47c7a37 into googlemaps:main Jan 3, 2026
10 checks passed
@vicb
Copy link
Contributor Author

vicb commented Jan 3, 2026

Thanks for the review and merging the PR quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants