Kadai2 miyahara - #31
Open
hikaru7719 wants to merge 3 commits into
Open
Conversation
knsh14
reviewed
Nov 22, 2018
| } | ||
|
|
||
| outputFile, err := os.Create(fileset.outputFileName) | ||
| defer outputFile.Close() |
There was a problem hiding this comment.
https://play.golang.org/p/S9YecKjLVo8
例えば、すでにあるディレクトリに対して os.Create を実行します。
当然エラーが返ってきますが、そのとき outputFile の中身はどうなっていますか？
その場合に outputFile.Close() を呼ぶとどうなるか試してみてください。
knsh14
reviewed
Nov 22, 2018
|
|
||
| // outputFilePath returns output file path to correspond input file path. | ||
| func (c Converter) outputFilePath(inputFileName string) string { | ||
| stringSlice := strings.Split(inputFileName, ".") |
There was a problem hiding this comment.
Mac だと /Applications/Slack.app/Contents/Resources/app.asar.unpacked/src/static/slack-menubar-highlight.png というパスに画像ファイルがあるんですが、正しく変換されますか？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
課題2のPRです。(まだ途中)
よろしくおねがいします。
io.Readerとio.Writer
テストを書いてみよう
1回目の宿題のテストを作ってみて下さい