Kadai2 yasu - #34
Open
yasuno0327 wants to merge 4 commits into
Open
Conversation
added 4 commits
November 19, 2018 15:37
knsh14
reviewed
Nov 20, 2018
| } | ||
| switch afterFormat { | ||
| case "png": | ||
| out, err := os.Create(file.Name() + ".png") |
There was a problem hiding this comment.
これだと foo.jpg というファイルの入力の場合に foo.jpg.png というファイル名になりませんか？
それは意図したものでしょうか？
knsh14
reviewed
Nov 20, 2018
| return err | ||
| } | ||
| for _, fileInfo := range files { | ||
| file, err := os.Open(directory + "/" + fileInfo.Name()) // Read file |
There was a problem hiding this comment.
できればfilepath.Join使ってほしいです。
あと対象のディレクトリのなかに更にディレクトリがあった場合、それも変換しようとしますが大丈夫でしょうか？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gopher道場第二回課題
io.Reader, Writerについて
kadai2/yasu/READWRITER.mdこちらに記載しました。
テスト
converterパッケージに対してそれぞれの関数が実行できるかのテストを書きました。