dojo7 [課題3-1] タイピングゲームを作ろう - #33
Open
asuke-yasukuni wants to merge 4 commits into
Open
Conversation
tenntenn
reviewed
Sep 24, 2019
| Input() <-chan string | ||
| } | ||
|
|
||
| type Reader struct{} |
tenntenn
reviewed
Sep 24, 2019
|
|
||
| type Reader struct{} | ||
|
|
||
| func (r *Reader) Input() <-chan string { |
Member
There was a problem hiding this comment.
empty structの場合はレシーバポインタにしちゃうとポインタ分スタックにメモリを確保するので func (Reader) Input <-chan stringのようにしておくと良さそう
tenntenn
reviewed
Sep 24, 2019
|
|
||
| go func() { | ||
| s := bufio.NewScanner(os.Stdin) | ||
| for s.Scan() { |
tenntenn
reviewed
Sep 24, 2019
|
|
||
| type Writer struct{} | ||
|
|
||
| func (w Writer) Output(outputText string) { |
tenntenn
reviewed
Sep 24, 2019
| func (r *Reader) Input() <-chan string { | ||
| ch := make(chan string) | ||
|
|
||
| go func() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
課題3-2が重いため、かなり簡素な感じにしました。
インターフェースの概念に慣れてないせいで、チャネルが絡むテストを書くのが以外に難しかったです。
最終的には割とちゃんと書けた気がします（気がするだけかもしれない）。
回答