hiroygo / 課題1 - #7
Draft
hiroygo wants to merge 7 commits into
Draft
Conversation
tenntenn
approved these changes
Jul 21, 2020
| // Unknown 不明な画像 | ||
| Unknown ImageType = "unknown" | ||
| // Jpeg Jpeg 画像 | ||
| Jpeg ImageType = "jpg" |
| // ToImageType 文字列を ImageType に変換する | ||
| // e.g. "jpg" => Jpeg | ||
| func ToImageType(s string) ImageType { | ||
| switch s { |
Member
There was a problem hiding this comment.
strings.ToLowerを使っても良いかもしれないですね。
https://golang.org/pkg/strings/#ToLower
| } | ||
|
|
||
| func imageTypeFromFileName(name string) ImageType { | ||
| extWithoutDot := strings.TrimLeft(filepath.Ext(name), ".") |
|
|
||
| func imageTypeFromFileName(name string) ImageType { | ||
| extWithoutDot := strings.TrimLeft(filepath.Ext(name), ".") | ||
| return ToImageType(strings.ToLower(extWithoutDot)) |
Member
There was a problem hiding this comment.
ここでToLowerするより、ToImageTypeの内部でやったほうが使う側の手間が省けます。
| var pathes []string | ||
| err := filepath.Walk(dir, func(visitPath string, f os.FileInfo, err error) error { | ||
| if err != nil { | ||
| return fmt.Errorf("WalkFunc error, %w", err) |
| ) | ||
|
|
||
| func parseArgs() (dir string, in, out imgconv.ImageType, err error) { | ||
| d := flag.String("d", "./", "変換の対象となる画像が格納されたディレクトリパス") |
| dir, inType, outType, err := parseArgs() | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err) | ||
| return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
課題1のPRになります。
お忙しいところ、すみませんが
レビューをよろしくお願いいたします。