Skip to content

Conversation

@kazaminosuke
Copy link

@kazaminosuke kazaminosuke commented Feb 8, 2026

Summary

This PR adds support for Minecraft 26.1 by introducing the JavaRuntimeEpsilon variant to MinecraftJavaProfile and the DefaultUserJvm variant to ArgumentType.

Motivation

Minecraft 26.1 (and recent snapshots) introduces:

  1. A new Java runtime requirement identified as java-runtime-epsilon.
  2. A new argument type default-user-jvm.

Currently, the launcher fails to parse the version manifest and arguments for these versions. This change allows Daedalus to correctly recognize and handle these new fields.

Changes

  • Added JavaRuntimeEpsilon to MinecraftJavaProfile and updated its string conversion methods.
  • Added DefaultUserJvm to ArgumentType (mapped via serde).

Verification

Verified that the launcher can now successfully parse and launch Minecraft 26.1 instances without crashing on the version check or argument parsing.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added support for the "java-runtime-epsilon" Java runtime environment, allowing users to select and configure this new Java runtime profile when launching Minecraft instances.

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

The PR adds a new JavaRuntimeEpsilon variant to MinecraftJavaProfile, updates as_str() and TryFrom<&str> to handle "java-runtime-epsilon", and adds #[serde(rename = "default-user-jvm")] to the DefaultUserJvm variant of ArgumentType.

Changes

Cohort / File(s) Summary
Minecraft runtime & argument enums
daedalus/src/minecraft.rs
Added JavaRuntimeEpsilon variant to MinecraftJavaProfile; updated MinecraftJavaProfile::as_str() and impl TryFrom<&str> to recognize "java-runtime-epsilon". Added #[serde(rename = "default-user-jvm")] to ArgumentType::DefaultUserJvm.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐇 A tiny hop, a variant new,
Epsilon joins the Java crew,
Strings aligned and serde set,
The codebase hums — no fret, no sweat,
Little change, big cheerful view!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding support for Minecraft 26.1 by introducing two new enum variants (JavaRuntimeEpsilon and DefaultUserJvm). It matches the changeset precisely.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kazaminosuke
Copy link
Author

@blarfoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant