registry: don't panic when store.New returns a nil session#291
Open
c-tonneslan wants to merge 1 commit into
Open
registry: don't panic when store.New returns a nil session#291c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Stores can legitimately return (nil, err) from New (e.g. backend unavailable). Registry.Get then dereferenced the nil session for session.name and session.store and crashed the request. Return the store's error instead. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288.
Registry.Getcalledstore.Newand then immediately dereferenced the returned session viasession.name = nameandsession.store = store. Stores can legitimately return(nil, err)fromNew(e.g. backend unreachable, decode failure, allocation error). When they do, the request crashes with a nil pointer dereference instead of propagating the error.Now: if the store returns a nil session, the error is recorded in the registry cache and returned to the caller. Existing happy-path tests still pass, plus a regression test covering a store that returns
(nil, err).