Skip to content

test: cover async-profiler JFR start command - #357

Merged
korniltsev-grafanista merged 1 commit into
grafana:mainfrom
arnabnandy7:chore/add-jfr-command-test
Aug 19, 2026
Merged

test: cover async-profiler JFR start command#357
korniltsev-grafanista merged 1 commit into
grafana:mainfrom
arnabnandy7:chore/add-jfr-command-test

Conversation

@arnabnandy7

@arnabnandy7 arnabnandy7 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Adds test coverage for the async-profiler JFR start command.

The test verifies that JFR recordings include both the configured recording file and the upload-interval-derived timeout.

Testing

./gradlew.bat :agent:test \
  --tests io.pyroscope.javaagent.AsyncProfilerDelegateCommandTest

Fixes #356.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@arnabnandy7
arnabnandy7 requested review from a team as code owners August 18, 2026 16:51
@arnabnandy7

Copy link
Copy Markdown
Contributor Author

@korniltsev @korniltsev-grafanista FYI the test that was missed has been added here. Please review.

@korniltsev-grafanista
korniltsev-grafanista enabled auto-merge (squash) August 19, 2026 01:56
@korniltsev-grafanista
korniltsev-grafanista merged commit d251a48 into grafana:main Aug 19, 2026
46 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JFR command has no test, only otlp. worth adding.

2 participants