Skip to content

Conversation

@n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Dec 10, 2025

Reverts #7348

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete revert of the "feat(cdn): add versioned artifact endpoints" feature. The primary goal of this revert is to remove the functionality that allowed CDN artifacts to be accessed via specific version IDs. This involves rolling back changes across the API services, CDN worker, and integration tests, ensuring that the system no longer supports or processes requests for historical schema versions through dedicated CDN paths.

Highlights

  • Versioned CDN Artifact Endpoints Removed: The feature allowing retrieval of CDN artifacts by specific version IDs has been fully reverted, eliminating dedicated endpoints for historical schema versions.
  • Storage Logic Simplified: The artifact storage mechanism no longer writes or manages separate versioned keys in S3, streamlining the process to focus solely on the latest artifacts.
  • CDN Worker Updates: The CDN worker's routing and handling for versioned artifact requests, including related analytics and headers, have been removed.
  • Test Cases Eliminated: All integration tests specifically designed to validate the versioned CDN artifact functionality have been removed, reflecting the removal of the feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR reverts the versioned CDN artifact endpoints feature. The changes correctly remove the associated code, tests, and documentation. The revert appears complete and correct.

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 8.13.0-alpha-20251210100453-97d4a5dcac9bbd950807941451b7bae0c4b5b905 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7399.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-7399.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 97d4a5dcac9bbd950807941451b7bae0c4b5b905

@n1ru4l n1ru4l merged commit 1cd44f6 into main Dec 10, 2025
27 checks passed
@n1ru4l n1ru4l deleted the revert-7348-adam/cdn-versioned-schema branch December 10, 2025 10:28
n1ru4l added a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant