-
Notifications
You must be signed in to change notification settings - Fork 122
Revert "feat(cdn): add versioned artifact endpoints" #7399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 645c301.
Summary of ChangesHello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a complete revert of the "feat(cdn): add versioned artifact endpoints" feature. The primary goal of this revert is to remove the functionality that allowed CDN artifacts to be accessed via specific version IDs. This involves rolling back changes across the API services, CDN worker, and integration tests, ensuring that the system no longer supports or processes requests for historical schema versions through dedicated CDN paths. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR reverts the versioned CDN artifact endpoints feature. The changes correctly remove the associated code, tests, and documentation. The revert appears complete and correct.
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7399.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7399.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Reverts #7348