Add support for edition 2024 - #1529
Merged
Merged
Conversation
Contributor
Author
|
@Vuhag123 @sampajano anything missing from my end? |
Collaborator
|
Looks good to me. One quick question: since this is supposed to stay in sync with protoc-gen-js, has support for Edition 2024 already landed there as well? |
Contributor
Author
|
Yes, check protocolbuffers/protobuf-javascript#258 |
Vuhag123
approved these changes
Jun 22, 2026
Vuhag123
left a comment
Vuhag123
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The change is minimal and keeps grpc-web's supported maximum edition in sync with protoc-gen-js. No concerns from my side. Approved.
mbissa
approved these changes
Jul 8, 2026
Vuhag123
added a commit
to Vuhag123/grpc-web
that referenced
this pull request
Jul 16, 2026
Vuhag123
added
release notes: yes
release notes: major
and removed
release notes: yes
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for editions 2024. Fixes #1516