New football models #14995
Merged
New football models #14995
+140
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A refactoring of our existing football models, to reduce duplication and allow them to work for upcoming changes to football sportblogs and match report pages. These are not currently being used anywhere. The work to have them replace the existing models, and be used on the aforementioned pages, will happen in future changes.
marjisound
approved these changes
Dec 12, 2025
Contributor
marjisound
left a comment
marjisound
left a comment
There was a problem hiding this comment.
This is a great improvement. The existing football types have duplicated data models, and switching to the V2 types will improve clarity and readability 👌
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @JamieB-gu 13 minutes and 33 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring of our existing football models, to reduce duplication and allow them to work for upcoming changes to football sportblogs and match report pages (#7396).
These are not currently being used anywhere. The work to have them replace the existing models, and be used on the aforementioned pages, will happen in future changes.