Set up web handler for hosted content #15006
Open
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
on-ye
reviewed
Dec 15, 2025
| canonicalUrl: '', | ||
| renderingTarget: 'Web', | ||
| // @ts-expect-error no config data | ||
| config: {}, |
Contributor
There was a problem hiding this comment.
This can be completed (at least partially) like so:
config: {
renderingTarget: 'Web',
assetOrigin: ASSET_ORIGIN,
darkModeAvailable: ... // if we can feed in the a/b test switches then we can populate this
}| title, | ||
| description: frontendData.standfirst, | ||
| // @ts-expect-error no config data | ||
| guardian: {}, |
Contributor
There was a problem hiding this comment.
Based on the createGuardian function is it best to populate the HostedContent["frontendData"] object with the Config object, as most of the fields like sentryHost, frontendAssetsFullURL, googletagUrl are needed for the pages? Or would you recommend we wait for the full spec of the page to be released before attempting to populate the window.guardian object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This sets up a basic initial web rendering path for hosted content in DCR, using the scaffolded layouts.
Why?
This is part of an ongoing piece of work to migrate hosted content to DCR. Setting this up enables us to test hosted content rendering locally using the usual dev setup as we build on the initial scaffolds.
This will need revisiting when we get closer to launch as it's currently not possible to provide the data required to populate
window.guardianor set up a lot of basic page config, but this will require changes in frontend and may be subject to the actual requirements of the pages themselves.