perf: syntax highlighting searches the saved state list from the start#30
Open
h-east wants to merge 1 commit into
Open
perf: syntax highlighting searches the saved state list from the start#30h-east wants to merge 1 commit into
h-east wants to merge 1 commit into
Conversation
h-east
commented
May 30, 2026
Owner
256d550 to
719e174
Compare
2d9574e to
c9620f5
Compare
719e174 to
9991544
Compare
c9620f5 to
92dd6d3
Compare
9991544 to
a40637c
Compare
92dd6d3 to
950791c
Compare
a40637c to
2339b40
Compare
950791c to
a966217
Compare
2339b40 to
d8e12d5
Compare
a966217 to
32b8b75
Compare
d8e12d5 to
b0b17c2
Compare
32b8b75 to
598b6e8
Compare
Problem: Looking up the saved syntax state for a line scans the state
list from the start every time, which is slow when highlighting
a large file in increasing line order.
Solution: Remember the last found entry and start the search there when it
is at or before the wanted line; the list is sorted, so the
result cannot be earlier. The highlighting is unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b0b17c2 to
e01b8fc
Compare
eb14f24 to
13a4672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.