Fix psqlrc test issue#437
Open
mddelk wants to merge 1 commit into
Open
Conversation
Add some postgres test support cleanup.
1. Pass `-X` when calling `psql`, to avoid loading user configuration.
We're using `psql` here to list databases, so we need clean output to parse.
This lets us avoid issues when `.psqlrc` files are present that result in additional stdout, such as:
```
\pset null '(null)'
```
2. Pass `exception: true` when running postgres `system` commands.
This makes errors here more obvious, e.g:
```
Failures:
1) Hanami::CLI::Commands::App::DB::Create single db in app postgres creates the database
Failure/Error: system(cmd_env, "dropdb --force #{database}", exception: true)
RuntimeError:
Command failed with exit 1: dropdb --force Null display is "(null)".
# ./spec/support/postgres.rb:25:in 'Kernel#system'
# ./spec/support/postgres.rb:25:in 'block (3 levels) in <top (required)>'
# ./spec/support/postgres.rb:24:in 'Array#each'
# ./spec/support/postgres.rb:24:in 'block (2 levels) in <top (required)>'
```
mddelk
marked this pull request as ready for review
July 12, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some postgres test support cleanup.
-Xwhen callingpsql, to avoid loading user configuration.We're using
psqlhere to list databases, so we need clean output to parse.This lets us avoid issues when
.psqlrcfiles are present that result in additional stdout, such as:exception: truewhen running postgressystemcommands.This makes errors here more obvious, e.g: