Skip to content

test: cover schema sync, PR scopeOptional dispatch, and infra deep links - #815

Closed
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/missing-test-coverage-1eb5
Closed

test: cover schema sync, PR scopeOptional dispatch, and infra deep links#815
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/missing-test-coverage-1eb5

Conversation

@cursor

@cursor cursor Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

Adds regression tests for recently merged behavior flagged by the test-coverage automation run on PR #813 (auto-sync harness schemas).

Risky behavior now covered

  1. Auto-synced v1 schema bundle — locks in upstream schema changes from harness-schema:

    • ai-eval step template alias on UnifiedTemplate
    • Stage-level inputs (replacing removed variables) on UnifiedStageNodeV1
    • Change Advisor advisory gating fields (user-groups, service-accounts, approvers-min-count, block-executor)
  2. Pull request scopeOptional dispatch — prevents 404s for account-scoped Code repos:

    • Omits config-default orgIdentifier/projectIdentifier when caller does not pass org_id/project_id
    • Forwards explicit org/project when provided
    • Documents scope guidance on all PR-related resource descriptions
  3. Infrastructure deep links (feat: [AIPLAT-1334]: Point infrastructure openInHarness at environment Infrastructure section #809)openInHarness resolves {environmentIdentifier} from query params when the API response omits environmentRef

Test files added/updated

  • tests/schemas/schema-bundle-contract.test.ts
  • tests/registry/pull-requests.test.ts
  • tests/registry/infrastructure.test.ts

Why these tests materially reduce regression risk

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (test coverage)

Checklist

  • pnpm test passes (targeted: schema-bundle-contract, pull-requests, infrastructure)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes
  • pnpm docs:check passes
Open in Web View Automation 

thisrohangupta and others added 2 commits August 14, 2026 00:27
Add regression tests for recently merged behavior:
- v1 schema bundle: ai-eval step alias, stage inputs (not variables),
  Change Advisor advisory gating fields from auto-synced harness schemas
- pull_request scopeOptional: omit config org/project unless explicit;
  document scope guidance on all PR-related resources
- infrastructure get: openInHarness resolves environmentIdentifier from
  query params when the API response omits environmentRef

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thisrohangupta
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

@thisrohangupta

Copy link
Copy Markdown
Collaborator

Closing in impact triage: the schema source changes are already on main; this dirty automated branch is a mixed regression snapshot with no remaining production fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants