test: cover schema sync, PR scopeOptional dispatch, and infra deep links - #815
Closed
cursor[bot] wants to merge 2 commits into
Closed
test: cover schema sync, PR scopeOptional dispatch, and infra deep links#815cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Add regression tests for recently merged behavior: - v1 schema bundle: ai-eval step alias, stage inputs (not variables), Change Advisor advisory gating fields from auto-synced harness schemas - pull_request scopeOptional: omit config org/project unless explicit; document scope guidance on all PR-related resources - infrastructure get: openInHarness resolves environmentIdentifier from query params when the API response omits environmentRef Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Collaborator
|
Closing in impact triage: the schema source changes are already on main; this dirty automated branch is a mixed regression snapshot with no remaining production fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged behavior flagged by the test-coverage automation run on PR #813 (auto-sync harness schemas).
Risky behavior now covered
Auto-synced v1 schema bundle — locks in upstream schema changes from harness-schema:
ai-evalstep template alias onUnifiedTemplateinputs(replacing removedvariables) onUnifiedStageNodeV1user-groups,service-accounts,approvers-min-count,block-executor)Pull request
scopeOptionaldispatch — prevents 404s for account-scoped Code repos:orgIdentifier/projectIdentifierwhen caller does not passorg_id/project_idInfrastructure deep links (feat: [AIPLAT-1334]: Point infrastructure openInHarness at environment Infrastructure section #809) —
openInHarnessresolves{environmentIdentifier}from query params when the API response omitsenvironmentRefTest files added/updated
tests/schemas/schema-bundle-contract.test.tstests/registry/pull-requests.test.tstests/registry/infrastructure.test.tsWhy these tests materially reduce regression risk
params→ deep-link bridge added in feat: [AIPLAT-1334]: Point infrastructure openInHarness at environment Infrastructure section #809.Type of Change
Checklist
pnpm testpasses (targeted: schema-bundle-contract, pull-requests, infrastructure)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses