Skip to content

test: cover FME rollout prompt, governance CRUD scopes, infra deep links - #837

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/missing-test-coverage-2e5a
Closed

test: cover FME rollout prompt, governance CRUD scopes, infra deep links#837
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/missing-test-coverage-2e5a

Conversation

@cursor

@cursor cursor Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

Adds regression tests for recently merged high-risk paths that only had partial or no test coverage:

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (test coverage)

Checklist

  • pnpm test passes (targeted: 78 tests in 3 files)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes
  • pnpm docs:check passes

Risky behavior now covered

Area Regression risk
FME rollout prompt scope validation Agents could invoke rollout workflow without valid scope or miss NYI steps in Harness-native mode
Governance CRUD scope injection Account/org policies could leak project scope on get/create/update/delete
Infrastructure deep links Broken openInHarness URLs when API shape varies (nested envRef, missing top-level envRef)

Test files added/updated

  • tests/prompts/feature-flag-rollout.test.ts (new)
  • tests/registry/governance.test.ts (+90 lines)
  • tests/registry/infrastructure.test.ts (+46 lines)
Open in Web View Automation 

Add regression tests for recently merged high-risk paths:

- feature-flag-rollout prompt: dual-mode scope validation (workspaceId vs
  orgId+projectId) and Harness-native NYI caveat surfacing (#806)
- policy/policy_set get/create/update/delete: verify resource_scope
  account/org/project param injection matches list behavior (#819)
- infrastructure deep links: nested environmentRef aliasing and
  environment_id param fallback when API omits environmentRef (#809)

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thisrohangupta

Copy link
Copy Markdown
Collaborator

Closing as superseded by newer follow-ups #842 and #845, which cover the same FME rollout, governance CRUD, and infrastructure paths against current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants