test: cover FME rollout prompt, governance CRUD scopes, infra deep links - #837
Closed
cursor[bot] wants to merge 1 commit into
Closed
test: cover FME rollout prompt, governance CRUD scopes, infra deep links#837cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for recently merged high-risk paths: - feature-flag-rollout prompt: dual-mode scope validation (workspaceId vs orgId+projectId) and Harness-native NYI caveat surfacing (#806) - policy/policy_set get/create/update/delete: verify resource_scope account/org/project param injection matches list behavior (#819) - infrastructure deep links: nested environmentRef aliasing and environment_id param fallback when API omits environmentRef (#809) Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged high-risk paths that only had partial or no test coverage:
feature-flag-rolloutprompt validates dual-mode scope (workspaceId vs orgId+projectId) and surfaces the Harness-native NYI caveat for steps that still require legacy workspace_id.policyandpolicy_setget/create/update/delete now assertresource_scopeaccount/org/project query-param injection — matching existing list tests so CRUD cannot drift from list behavior.openInHarnessfalls back toenvironment_idwhen the API omitsenvironmentRef, and aliases nestedinfrastructure.environmentRefon list items.Type of Change
Checklist
pnpm testpasses (targeted: 78 tests in 3 files)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpassesRisky behavior now covered
openInHarnessURLs when API shape varies (nested envRef, missing top-level envRef)Test files added/updated
tests/prompts/feature-flag-rollout.test.ts(new)tests/registry/governance.test.ts(+90 lines)tests/registry/infrastructure.test.ts(+46 lines)