Skip to content

feat(oidc): Creation Of New Provider Type Option For Provider Config - #194

Merged
RyanDerr merged 1 commit into
llb-azure-entra-overage-supportfrom
rderr-provider-type
Aug 31, 2026
Merged

feat(oidc): Creation Of New Provider Type Option For Provider Config#194
RyanDerr merged 1 commit into
llb-azure-entra-overage-supportfrom
rderr-provider-type

Conversation

@RyanDerr

Copy link
Copy Markdown
Member

Overview

This PR adds a new optional ProviderType field to the OIDC Config struct. The purpose of this option is to allow callers to identify which OIDC provider they are configuring so that provider specific logic can be triggered in cap.

Currently the only initial supported type is Azure, which will enable in the future resolving group overage claims.

Changes

  • Creation of a new file provider_type.go within the oidc package which contains the following:
    • ProviderType string type
    • ProviderTypeAzure constant to denote the Azure provider
    • A SupportedProviderType helper function that validates if a given provider type is supported within the library
  • Addition of the ProviderType field to the Config struct in addition to the WithProviderType option function that sets ProviderType on a Config during construction.
  • Modification of the Config methods:
    • Validate which now rejects and throws an error any non-empty provider type ProviderType supplied that is not currently known and supported.
    • Hash adds the ProviderType in the hash input to be computed, such that the hash is consistent across all config fields.

@RyanDerr RyanDerr self-assigned this Aug 27, 2026
@RyanDerr
RyanDerr force-pushed the rderr-provider-type branch from 24edc1d to af78648 Compare August 27, 2026 20:52
@RyanDerr
RyanDerr marked this pull request as ready for review August 27, 2026 21:04
@RyanDerr
RyanDerr requested a review from a team as a code owner August 27, 2026 21:04

@louisruch louisruch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread oidc/provider_type.go Outdated
@RyanDerr
RyanDerr force-pushed the rderr-provider-type branch from 68f6ee4 to 7320d18 Compare August 31, 2026 13:32
@RyanDerr
RyanDerr merged commit 7320d18 into llb-azure-entra-overage-support Aug 31, 2026
2 checks passed
@RyanDerr
RyanDerr deleted the rderr-provider-type branch August 31, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants