FE-1132: Add RightClickMenu to DS#8950
Conversation
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 852e089. Bugbot is set up for automated code reviews on this repo. Configure here. |
lunelson
left a comment
There was a problem hiding this comment.
Two things jump out at me
- you can't do it in a single press-release cycle, i.e. mouse-down, drag to the position of the item you want, release to select (as normal context menus can do)
- I'm not a fan of zoom transitions on drop-down menus, I would use position only, or no transition at all
@lunelson - thanks for the feedback. Agree with you about the menu animation, I've updated it so that Menu only has a subtle fade in/out animation instead. Re the right click issue, agree with you again, but this behaviour is actually driven by ark-ui - to fix it I'd need to override/re-implement the behaviour, which took claude ~150 loc. Claude also mentioned that right click behaves the way we expect it on windows + linux, and that this is an OSX only issue. I haven't/can't test to see if thats correct, but assuming it is, I think all things considered its not worth fixing this for now. |
🌟 What is the purpose of this PR?
Adds a right click menu component to the DS
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: