Avoid using Alternative unnecessarily#1304
Open
tomjaguarpaw wants to merge 3 commits intohaskell:masterfrom
Open
Avoid using Alternative unnecessarily#1304tomjaguarpaw wants to merge 3 commits intohaskell:masterfrom
tomjaguarpaw wants to merge 3 commits intohaskell:masterfrom
Conversation
It just wasn't used. Maybe left over from an older version when it was used.
Instead of doing Alternative in m, do it in IO and then liftIO into m
hasufell
reviewed
Jan 20, 2026
| -- TODO: don't do alternative on IO, because it hides bugs | ||
| (name, mid, ver) <- handleIO (\_ -> throwE DistroNotFound) $ lift $ asum | ||
| [ liftIO try_os_release | ||
| (name, mid, ver) <- join $ liftIO $ handleIO (\_ -> pure (throwE DistroNotFound)) $ fmap pure $ asum |
Member
There was a problem hiding this comment.
Well yeah... the interesting part is getting rid of asum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some were completely redundant, some were just unnecessary with a bit of restructuring. This is also a step towards the TODO in
getLinuxDistro: "don't do alternative on IO, because it hides bugs".