Conversation
…t/trimEnd TrimMode's own JSDoc (the wrappable/separator/whitespace/unicode level breakdown) was marked @ignore, hiding it from generated docs entirely despite being a genuinely public, re-exported type. Un-ignored it and turned the prose bullet list into a proper table with example characters per level, plus explicit guidance on when to reach for 'wrappable' vs 'unicode'. Added @see cross-references between trim/trimStart/trimEnd so each one's docs page links to its two siblings.
Found while investigating why TrimMode wasn't showing up anywhere on the website despite un-ignoring its JSDoc (previous commit): the website metadata builder requires an explicit @SInCE tag on every documented member, including type aliases and interfaces attached as a "companion" to their function (the relatedTypes mechanism that lets e.g. CapitalizeOptions render inline on capitalize's own page instead of needing a standalone page). But this repo's own convention (see AGENTS.md, and existing types like RgbColor/CapitalizeOptions) is that a companion type does *not* get its own @SInCE - it inherits relevance from whatever function(s) it's attached to, and `since` isn't even part of WebsiteRelatedType's shape once attached. This silently dropped every convention-following companion type from the website, not just TrimMode - verified by rebuilding all 20 categories: 79 relatedTypes attachments across the whole codebase (SortFn, DateLike, RgbColor, MemoizeOptions, CapitalizeOptions, and TrimMode among them) were missing and are now restored. Scoped the exemption to kind === 'type' | 'interface' only - functions still require @SInCE (checked separately and enforced by `pnpm coherency`), this only relaxes the redundant "double-safety" check for things that were never supposed to need their own @SInCE in the first place.
Contributor
✅ PR Validation Passed
📋 Pipeline Status
📊 Code Coverage
🧬 Mutation Testing
🌐 Runtime Compatibility
⏱️ Benchmarks
ℹ️ About this report
🤖 Generated by @helpers4 CI • 2026-07-29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.