Fix Gradio Playground MCP argument parsing - #1081
Open
lakshayxi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1080.
Summary
argumentsfor MCPcall_toolactions at the web preprocessing boundary./web/steppath.AGENTS.md.Tests
PYTHONPATH=src:envs uv run pytest tests/core/ -qPYTHONPATH=src:envs uv run pytest tests/ -quv run usort check src/openenv/core/env_server/serialization.py tests/core/test_mcp/test_mcp_types.py tests/core/test_web_interface_mcp.pyuv run ruff format src/openenv/core/env_server/serialization.py tests/core/test_mcp/test_mcp_types.py tests/core/test_web_interface_mcp.py --checkuv run ruff check src/openenv/core/env_server/serialization.py tests/core/test_mcp/test_mcp_types.py tests/core/test_web_interface_mcp.pyFull suite:
1641 passed, 129 skipped.Note
Low Risk
Scoped to the web preprocessing deserialization path with clear validation boundaries and broad test coverage; no auth or data-model changes.
Overview
Fixes Gradio Playground and
POST /web/stepfailures when MCPcall_toolactions sendargumentsas a JSON string (textbox) instead of an object.deserialize_action_with_preprocessingnow JSON-decodes stringargumentsfortype: call_toolinto a dict on a copy of the payload (input is not mutated).deserialize_actionstays strict—stringargumentsstill fail validation. Malformed JSON, arrays, and scalar JSON strings still raiseValidationError.Regression tests cover serialization edge cases and an integration test on
/web/step.AGENTS.mddrops the old workaround note about the broken Playground Step form.Reviewed by Cursor Bugbot for commit 9b765f8. Bugbot is set up for automated code reviews on this repo. Configure here.