Port ChartHistogram from FireFly Core (#196) #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Apostlex0 <[email protected]>
Apostlex0
force-pushed
the
feature/chart-histogram
branch
from
09f7b2a to
a324dda
Compare
Author
|
@EnriqueL8 pr's ready for review, and since there were some differences in the db operations of ffcore and ffcommon, please let me know if you spot anything that needs fixing. |
EnriqueL8
reviewed
Dec 12, 2025
pkg/dbsql/histogram_sql.go
Outdated
| @@ -0,0 +1,178 @@ | |||
| // Copyright © 2024 Kaleido, Inc. | |||
Contributor
There was a problem hiding this comment.
Need to be 2025 and make sure to add your own Copyright if applicable
EnriqueL8
reviewed
Dec 12, 2025
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Thanks @Apostlex0 - would be good to add some tests before I properly review
Signed-off-by: Apostlex0 <[email protected]>
Apostlex0
force-pushed
the
feature/chart-histogram
branch
from
61e558b to
7c64006
Compare
Author
|
@EnriqueL8 ready for review! |
Signed-off-by: Apostlex0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #196