fix: make map types public#1313
Merged
simongdavies merged 1 commit intohyperlight-dev:mainfrom Mar 17, 2026
Merged
Conversation
Contributor
|
Need to make the field on MemoryRegion pub as well: Maybe a integration test that uses |
8a2c645 to
e7add2c
Compare
Contributor
|
verified the latest changes work in HL-wasm |
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
e7add2c to
88c7fe7
Compare
jsturtevant
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes visibility in the memory region handling code in
src/hyperlight_host/src/mem/memory_region.rsfor hyperlight-wasm use.Visibility improvements:
MemoryRegionTypeenum public, allowing it to be used outside of the current crate.SurrogateMappingenum public, so it can be accessed from other modules or crates.surrogate_mappingmethod onMemoryRegionTypepublic, enabling external code to determine the surrogate mapping for a given memory region type.