Add the assemble.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble#491
Open
gouniLee wants to merge 8 commits intodevelopmentfrom
Open
Add the assemble.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble#491gouniLee wants to merge 8 commits intodevelopmentfrom
assemble.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble#491gouniLee wants to merge 8 commits intodevelopmentfrom
Conversation
gouniLee
changed the title
assembleJson.mjs file to enable generating the final merged [locale].json files by using the `ilib-assemble toolassembleJson.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble tool
gouniLee
changed the title
assembleJson.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble toolassembleJson.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble
gouniLee
changed the title
assembleJson.mjs file to enable generating the final merged [locale].json files by using the ilib-assembleassemble.mjs file to enable generating the final merged [locale].json files by using the ilib-assemble
ehoogerbeets
requested changes
Apr 16, 2026
| @@ -0,0 +1,50 @@ | |||
| { | |||
| "ethiopic": { | |||
Contributor
There was a problem hiding this comment.
Why is this file in the PR?
| @@ -0,0 +1,154 @@ | |||
| import path from 'path'; | |||
Contributor
There was a problem hiding this comment.
Need standard file header
| const file = queue.shift(); | ||
| const fileContent = readFile(path.join(process.cwd(), "js/lib", file)); | ||
| if (fileContent) { | ||
| fileCache.set(file, fileContent); |
Contributor
There was a problem hiding this comment.
Since the reDependentPattern is re-used, you need to reset the index to re-initialize it before using it with another string:
reDependentPattern.lastIndex = 0;
| jsFiles.forEach(file => { | ||
| const fileContent = fileCache.get(file) || readFile(path.join(process.cwd(), "js/lib", file)); | ||
| if (fileContent) { | ||
| for (const match of fileContent.matchAll(reDataPattern)) { |
| * @returns {object} Flat map of timezone ID to parsed timezone data | ||
| */ | ||
| function assembleZoneinfoData(zoneinfoPath, readFile) { | ||
| const zoneinfoData = {}; |
Contributor
There was a problem hiding this comment.
This is missing zonetab.json and a few other things. Please take a look at https://github.com/iLib-js/ilib-webpack-plugin/blob/master/ilib-webpack-plugin.js#L196 for how this should be updated
| @@ -0,0 +1,67 @@ | |||
| import path from 'path'; | |||
Contributor
There was a problem hiding this comment.
Need standard ilib open-source header
| } | ||
| result[locale]["ilib.data.zoneinfo"] = zoneinfoData; | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
Need special handling for charsets, charmaps, and normalizations. Please see https://github.com/iLib-js/ilib-webpack-plugin/blob/master/ilib-webpack-plugin.js#L157
| @@ -1,4 +1,4 @@ | |||
| # Copyright (c) 2012-2024, JEDLSoft | |||
| # Copyright (c) 2012-2026, JEDLSoft | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2012-2026, JEDLSoft | |
| # Copyright (c) 2012-2024, 2026, JEDLSoft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
ReleaseNoteshas added or is not needed.NodejsandChrome Browser.QT/QML.Description
assemble.mjsfile to enable generating the final merged[locale].jsonfiles by using the `ilib-assemble toolassemble.mjsfile scans it (including its dependencies)related PR
Usage:
ilib-assemble --mergeJson --ilibincPath ./js/assembleData/ilib-inc.js --localefile ./js/assembleData/locales.json --customLocalePath ./js/assembleData/customData assembled[locale].jsonfiles, e.g., ko-KR.json.