Add ability to correct TopoSplit shortwave radiation by configured vegetation#55
Merged
Add ability to correct TopoSplit shortwave radiation by configured vegetation#55
Conversation
…ntation Switch to use numexpr for vegetation adjustment to the solar radiation and expand the method documentation.
Update the Solar HRRR logic and allow for vegetation adjustments via the .ini file. This is identical to the default solar method and also uses the same adjustment calculation according to Link and Marks 1999
arobledano
approved these changes
Feb 10, 2026
Contributor
arobledano
left a comment
There was a problem hiding this comment.
woooops, I missed that one. Looking good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to the implementation of the theoretical shortwave calculation and is triggered via
.inikeycorrect_veg.Partially addresses: #43
Also speeds up the calculation using the numepxr library.