Fix npm critical security issues#48
Open
ignaciocarre wants to merge 1 commit intoiaincollins:masterfrom
Open
Conversation
Owner
|
Thanks for raising this, I'll test it and if it al seems fine merge it and get it published later today (good reminder that I should really automate the pipeline…) |
Author
|
Great @iaincollins!, I did run all the tests in my local env, all passing here. Automation sounds even better, having all those greens on this PR would be a relief 😅 Hope you can merge it asap, thanks! |
|
It looks like the tasks laid out here have been taken care of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade dependencies with critical npm security warnings
Detail
After running npm audit we found that sdtt was having 1 critical notice:
Checklist
If you would like your code to be merged into master and released, please complete this checklist and raise a Pull Request.
git rebase origin/master).npm audit fixto fix flagged issues is appreciated.