Move reading_time to posts table from being calculated on-the-fly #3
Open
Move reading_time to posts table from being calculated on-the-fly #3
Conversation
9e9fb89 to
223dda6
Compare
223dda6 to
9ba2ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the fields returned from the API is
reading_time. This is not a static field stored in the DB, rather a dynamic field calculated on request. We’d like to makereading_timeinto a static field stored on the posts table, and returned “normally” from the API.next step (optional):
Notes
Migration
Everything is in one PR, however, release wise, this would be split up into multiple PR's in following order:
reading_timeis stored in db for new posts, or saves3.1 depending on the size of the table:
3.1.1 small - do it with this sort of backfill
3.1.2 big - probably a better choice to do the backfill by separately running the script, use
APIorSQL queries, to have better control over load on the DBextra-attrsand use real db columnTests
Tests only run correctly in CI if PR is in Ghost.