Skip to content

ci: Fix comment #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krlmlr merged 1 commit into from
Jan 13, 2026
Merged

ci: Fix comment #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ jobs:

- id: versions-matrix
# Only run for:
# - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-"
# - pull requests if the base repo is different from the head repo
# - pull requests if the branch name starts with "cran-"
Comment on lines +137 to +138
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is logically incorrect. Based on the condition at line 142, this step runs for:

  • ALL non-pull-request events (not just pull requests)
  • Pull requests where repos are different OR branch starts with "cran-"

The updated comment incorrectly implies this only runs for pull requests. The comment should clarify that for pull requests, it runs when EITHER condition is met (different repos OR cran- branch), and it also runs for all non-pull-request events (subject to the workflow_dispatch constraint).

Copilot uses AI. Check for mistakes.
# Do not run for:
# - workflow_dispatch if not requested
# Always run for other events.
Expand Down