Finish transforms - #3
Open
btbest wants to merge 10 commits into
Open
Conversation
And use the more clearly defined responsibilities: Now that simplification is handled in a clear place, the specific cases of Affine (scale, translation etc) can do the inverse of simplification and compose into Affine.
And clarify Scale special cases
Now that they're officially affines
* Refactor construction in _ndim_by_payload and usage sites * _source_ndim_must_eq_target_ndim is now obsolete (True just means delta=0, False means delta=None) * Update/Implement _ndim_by_payload where now more detail can be expressed (ProjectAxis, ByDimension, Bijection, Sequence) * No qualitative changes to validation yet, i.e. no genuine use of the new constraint information
And add IDs for ProjectAxis compose test
* In particular ProjectAxis, Bijection and Sequence * No more overriding _validate_bound_axes: There are no special cases anymore. All constraints are expressed by _ndim_by_payload and validated by the Transform base class. * ByDimension can now just offload validation to base Transform class, meaning also no new tests necessary.
btbest
force-pushed
the
finish-transforms
branch
from
August 14, 2026 06:09
6507ee8 to
d54b511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements the remaining features that transforms really need: clean composition, simplification and exact dimensionality validation.
It's finished and ready to merge, just leaving it off main to finish ilastik first