Skip to content

Conversation

@idubnori
Copy link
Collaborator

@idubnori idubnori commented Nov 25, 2025

Description

  • Button display adjustments: Exclude those shown in the bottom bar
  • Button order: Based on gphotos and so on
  • Grouping: Info, Misc, Move/Add/Delete functions
  • Details : please look at Screenshots section

Fixes # (issue)

  • N/A

How Has This Been Tested?

Manually Tests on iOS Simulator

  • Pressing the kebab button displays the menu
  • Clicking “Info” opens the bottom sheet
  • Action buttons are not displayed within the bottom sheet
  • Buttons contained within bottom buttons are not displayed in the kebab menu
  • Buttons function correctly
  • Visually checked in dark / light theme

Screenshots (if appropriate)

screen-recording-immich-16.mp4

Ref. Google Photos below

google-photos-3.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

  • investigation / initial impl / refactoring

@idubnori idubnori force-pushed the feature/kebab-menu-1 branch from 52cd932 to be91262 Compare December 12, 2025 16:03
@idubnori idubnori changed the title feat(mobile): Move bottom sheet action buttons to kebab menu feat(mobile): move buttons in the bottom sheet to the kebabu menu Dec 12, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff are hard to see. recommend viewing the modified file.

@idubnori idubnori marked this pull request as ready for review December 12, 2025 16:52
Copy link
Member

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you

@alextran1502 alextran1502 merged commit b10a8ba into immich-app:main Dec 15, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants